-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic templates personalisation #597
Fix dynamic templates personalisation #597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 85.18% 85.19% +0.01%
==========================================
Files 33 34 +1
Lines 999 1027 +28
Branches 136 138 +2
==========================================
+ Hits 851 875 +24
- Misses 84 87 +3
- Partials 64 65 +1
Continue to review full report at Codecov.
|
Duplicate of #593 |
Thanks for taking the time to help out with this PR. While this is a duplicate of an existing PR, I'm going to also review this PR to determine if we can somehow utilize both implementations. With Best Regards, Elmer |
How to see conflict and how to fix it ? |
Hey @wojtek-fliposports, regarding the merge conflict, I took care of it. |
Even though we did not merge this one, this PR was useful in getting support for this feature out and I'll be drawing inspiration from this PR for the v6 of this SDK, which is currently under development. As a small token of appreciation, we would love to send you some swag. Please fill out this form so that we can hook you up. With Best Regards, Elmer |
Fixes
#591
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.